The old proverb "be prepared for the worst but hope for the best" still holds.

My wife's and my experience during our 10 days in Madrid and Andalucia (Sevilla, Cordoba, Granada) and 8 days in Catalonia (mostly in Barcelona) have been very trouble free and safe. The only scam we saw and avoided was in Madrid (the map extended and hands under the paper pickpocket trick).

Barcelona was particularly reassuring in the light of the many adverse reports in the Net. The police presence was most palpable (on horseback, cars and motorcycles). The loiterers in the plazas were all interogated. No one approached us unsolicited and we were able to go about enjoying the sights feely.